[Consolidation] redefining shortcuts handled by Codemirror

[WhiteNoise]

Some Keyboard shortcuts are used by codemirror.
When the user binds these shortcuts to some other function, things can get weird (often a concatenation of effects).

References:

CTRL-UP/DOWN => Broken Swap line up/down

Steps to reproduce Step 1. Bind the “Swap line up” and “Swap line down” hotkeys to something. I have them as Ctrl+Up and Ctrl+Down respectively. Step 2. Create the following lines in your editor: 1 2 3 DEMONSTRATING SWAP LINE UP Step 3. Put cursor on “3” Step 4. Use swap line up hotkey DEMONSTRATING SWAP LINE DOWN Step 3. Put cursor on “1” Step 4. Use swap line down hotkey Expected result For swap line up, lines should be reordered like this: 1 3 2 For swap line down, lines shou…

Mapping back/forward shortcuts to Cmd+[ and Cmd+] still triggers their default behavior

Steps to reproduce I got used to use Cmd+[ and Cmd+] to navigate back and forward which is standard in most applications. But it seems the same combination is used to indent/unindent in obsidian. And when I bind it to navigate back and forward, indent/unindent is not unbound and sometimes they both fire so you navigate and it is indented in the same time. Expected result Only navigation is triggered not indenting. Actual result Both indent and navigation are triggered. Environment Operat…

Back/forward navigation doesn't really work

I have a issue with the back/forward shortcuts (which are bound to Alt+Left/Right on my platform (Linux)): Rarely, they seem to work, moving me back or forward one step in the sequence of recently viewed documents, as I’d expect. But other times, they either appear to move me one or two steps forward or back (like there’s some debouncing that’s not being done correctly), do nothing, or move my cursor to the beginning/end of the line in the current document. Is this behavior somehow indended? Di…

Markdown files truncated. Missing text

Steps to reproduce Unfortunately, this is probably not reproducable for others. It happens randomly to me every day. I add a dozen or so notes. When I come back to review them later on, they are missing text at the end of the markdown file. Expected result I expect that there would be no missing text. Actual result Text is missing. Environment Operating system: Linux Ubuntu 20.04 Obsidian version: 0.8.14 Additional information My vault is inside a Dropbox managed directory. Using Dropbox v…

[bee]

I have this same issue.

[cnr]

So, does this mean this bug was this already addressed? Or is it in the process of being addressed?

[WhiteNoise]

It will be addressed at some point.

[sam.baron]

Steps to reproduce

1. Create a new note in edit mode
2. Add text to note
3. Navigate to a different note
4. Return to new note
5. Delete using hotkey ctrl+delete

Expected result

Pane is empty and note should be deleted.

Actual result

Pane is empty, but note is not deleted. Text in note is deleted.

Environment

• Operating system: Windows 10

• Obsidian version: 0.8.2

---

Additional information

• I am using Obsidian trash.
• I am creating new notes in one specified folder.
• This bug only happens under specific conditions:
  • Keep the note in the folder it was created. If I move the note, this does not occur.
  • In edit mode
  • Must add text to newly created note
  • Must use hotkey

[snuki]

Same is happening for me (I even used same keyboard shortcut as mentioned in the description)

[luckman212]

Obs 0.10.7 / macOS 11.1

I have “Delete Note” hotkey assigned as Command+DEL (delete right aka fwd delete)

I just noticed today that when invoking this key, Obsidian will also delete the entire line that the cursor is on, while simultaneously popping the confirmation box. If the user hits “Cancel” without looking carefully, they will miss this fact and face data loss (as I did…)

Can this be fixed? In general if hotkeys are providing 2 functions, they should not be assignable or a warning should be displayed.

[ledet]

Steps to reproduce

• Change the command+[ hotkey to Navigate back
• Open a note and go to a line with an indented list item
• Press command+[
• You’ll be on the previous page, go back to the note with the list
• You’ll see the list item was left indented

Expected result

Navigation without the indent

Actual result

Both

Environment

• Operating system: OSX 10.15.7

• Obsidian version: v0.10.9 installer v0.9.20

[luckman212]

I just noticed this (again, apparently) when I tried to map ⌘+] to Toggle Right Pane and suddenly everything was indenting.

Is this one of those things that the upgrade to CM6 will resolve?

[WhiteNoise]

This issue has nothing to do with cm5/cm6

[luckman212]

@WhiteNoise

This issue has nothing to do with cm

Sorry. The title “redefining shortcuts handled by Codemirror” threw me off

[pjeby]

I’ve tentatively identified the root cause for this bug, and implemented a workaround in one of my plugins; see this Github comment for technical details on the cause and the code of the workaround.

[mano]

I’ve got a plugin working that unsets some code mirror hotkeys. I’ll try to get it added to the community plugins.

[WhiteNoise]

this will be fixed in 0.11.10

[Ampa]

Ctrl + M minimizes the Obsidian window, and can not be over-ridden by reassigning the shortcut.

I assume this is hardwired into Codemirror?

Is there any way to disable it? Drives me crazy!!

Thanks

[WhiteNoise]

ctrl-m is hardwired in electron. we will try to fix that too.