Keyboard shortcuts seem to be ignoring check conditions of commands

Bug graveyard
1

Steps to reproduce

  1. Download and install the obsidian-note-archiver plugin (or any other plugin that registers a command which uses a checkCallback or editorCheckCallback)
  2. create a dummy note, and configure the plugin to archive notes in an Archive/ folder without any grouping
  3. go to the dummy note dummy.md and see that the command to “Archive Note” is present when you use the command toolbar
  4. set up a keyboard shortcut for the “Archive note” command
  5. archive the note using the keyboard shortcut
  6. once it has moved to the Archive/ folder, see that the command to “Archive note” doesn’t show up in the command toolbar
  7. apply the keyboard shortcut again and see that it worked and the note was moved to Archive/Archive/dummy.md

Did you follow the troubleshooting guide? [Y/N]

Y

Expected result

the last step shouldn’t happen - since a note is already in the archive folder, the note should not be moved again

Actual result

the last step happens - the note is archived twice

Environment

SYSTEM INFO:
Obsidian version: v1.3.4
Installer version: v1.1.9
Operating system: Darwin Kernel Version 22.4.0: Mon Mar 6 21:01:02 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T8112 22.4.0
Login status: logged in
Catalyst license: none
Insider build toggle: off
Live preview: on
Legacy editor: off
Base theme: light
Community theme: none
Snippets enabled: 0
Restricted mode: off
Plugins installed: 20
Plugins enabled: 19
1: Periodic Notes v0.0.17
2: Editor Syntax Highlight v0.1.3
3: Calendar v1.5.10
4: Dataview v0.5.56
5: Kanban v1.5.3
6: Readwise Official v2.0.1
7: Templater v1.16.0
8: Tasks v3.10.0
9: Advanced Tables v0.18.1
10: Outliner v4.7.1
11: Folder Note v0.7.3
12: Full Calendar v0.10.7
13: Buttons v0.4.19
14: Linter v1.15.2
15: Spaced Repetition v1.10.1
16: Icon Folder v2.1.0
17: Tag Wrangler v0.5.8
18: Obsidian42 - BRAT v0.7.0
19: Note archiver v0.1.0

Additional information

the plugin above is currently in beta as of this writing and can be installed with brat thenomadlad/obsidian-note-archiver. I’m working on testing and publishing the plugin now

2

We don’t take big reports involving third party plugins and this is not the right category for API problems.

3

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.