[Consolidation] - When the focus is on a Modal\Dialog window, other panes should not be affected

When the focus is on a Modal\Dialog window, other panes should not be affected.
Notable examples

  • Delete modal window
  • Settings modal window

Steps to reproduce

  • Have a pane open in edit mode
  • Click vertical tripple dot
  • Choose “Delete file”
  • Repeatedly press “Tab” key
  • Tabs are written into underlying file

Expected result

Ideally, tab would navigate among available options/buttons.
Associated request: Keyboard shortcuts for dialog modals

But most importantly, Dialogue should block modification of underlying window as described in https://en.wikipedia.org/wiki/Modal_window

Actual result

By use of keyboard, unexperienced user can cause a lot of unnoticed edits / data-destruction in greyed-out underlying window.

Environment

  • Operating system: Windows 7
  • Obsidian version: 0.10.6
2 Likes

Repro:

  • Obs 0.10.8
  1. Open note & place cursor in note
  2. Open settings via hotkey (e.g. ⌘cmd+, on macOS)
  3. Settings dialog opens
  4. type some stuff on keyboard, it passes thru the settings modal dialog and into the note, potentially damaging it

Video:

will be fixed in 0.10.9

2 Likes

Not sure but perhaps it would be convenient to add standard Keyboard shortcuts for dialog modals while working on modals.